dangernoodle-io / breadboard / 29316430005

96%

push

github

refactor: delete the bb_pub/bb_sink_* cluster (bb_pub, bb_pub_info, bb_pub_rtos, bb_pub_telemetry, bb_sink_http, bb_sink_http_telemetry, bb_sink_mqtt, bb_sink_udp, bb_sink_ws, bb_mqtt_telemetry, bb_telemetry) (#858)

One PR removes all 11 components + their platform backends + 17 host
test files in a single commit so consumers die alongside their producer,
closing the boundary-orphan failure mode that killed three prior
incremental wave attempts.

bb_net_health (sole surviving consumer): drops the dead adaptive-backoff
#if block + 4 Kconfig symbols, the zero-callsite
bb_net_health_register_health() plus its net_section_get()/telemetry-source
glue, and the four http_* fields (consec_failures/tls_fail/last_status/
connected) from the snapshot struct, cache struct, JSON emitters, and both
JSON-Schema literals (net.health SSE topic, /api/diag/net) -- mqtt_*
fields (including mqtt.tls_fail) are untouched.

Also removes: orphaned NVS namespace/key SSOT constants owned solely by
the deleted cluster (BB_SINK_HTTP_NVS_NS, BB_PUB_NVS_NS,
BB_NV_KEY_HEADERS, BB_NV_KEY_PATH_TMPL, BB_PUB_NVS_KEY_INTERVAL,
BB_PUB_NVS_KEY_ENABLED) and a dead cross-component static_assert in
bb_event_common.c tying CONFIG_BB_EVENT_MAX_PAYLOAD to the now-gone
CONFIG_BB_PUB_TELEM_SERIALIZE_MAX; test_v2_golden.c's info-telemetry
envelope goldens (tied to bb_pub_info) -- the widget-fixture and
health-slice goldens are untouched; composition (bbtool.toml
capability.core/smoke), platformio.ini dead -D flags, components/README.md
index, sdkconfig.defaults.esp32 comment, and stale prose citing the
deleted components as exemplars in surviving files.

fence + coverage baselines shrink-pruned via the sanctioned
--update-baseline; 59 coverage-baseline entries pointing at now-deleted
files were hand-removed (bbtool doesn't prune missing-file entries,
B1-917).

Subsumes B1-906 (fake /api/diag/net HTTP health fields) and B1-907
(net_health telemetry-source dead code) -- both were exactly the code
re... (continued)

6897 of 7535 branches covered (91.53%)

Branch coverage included in aggregate %.

11604 of 11879 relevant lines covered (97.68%)

2348.96 hits per line