ruby-grape / grape / 29194635866

97%

master: 97%

Pull #2795

github

Encapsulate namespace_reverse_stackable behind rescue-handler methods

namespace_reverse_stackable existed only to store rescue-handler maps, yet it
was a public attr_reader that callers reached into with raw keys from two
different files (the rescue_from write and the endpoint read). That's how the
base-only handlers write/read drifted onto mismatched stores.

Make the store internal (protected, still used by inherit_from/copy_state_from/
to_hash) and expose intent-revealing methods on InheritableSetting instead:
rescue_handlers / base_only_rescue_handlers (merged, child-scope-first) and
add_rescue_handlers(mapping, subclasses:). The DSL write and endpoint reads go
through those, so there's one place that knows the key, store and merge.

The reverse-ordering behaviour stays covered by ReverseStackableValues' own
spec; the InheritableSetting specs that poked the raw store are replaced with
tests for the new methods.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

1127 of 1222 branches covered (92.23%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 2 files covered. (100.0%)

3597 of 3665 relevant lines covered (98.14%)

23307.39 hits per line