ruby-grape / grape / 29194177443

97%

master: 97%

Build Type

Pull #2794

github

Committed by ericproulx

Commit Message

Fix base-only rescue handlers never firing

`rescue_from Klass, rescue_subclasses: false` registered its handler in
`namespace_reverse_stackable[:base_only_rescue_handlers]` (dsl/request_response.rb),
but the error middleware options read `:base_only_rescue_handlers` from
`namespace_stackable` via `namespace_stackable_with_hash`. Those are two
different stores, so the read was always empty and base-only handlers never
ran — the exception propagated uncaught.

Read base-only handlers from the same reverse-stackable store the write uses,
sharing the child-precedence merge with `rescue_handlers` via
`merged_reverse_stackable`. This also gives base-only handlers the same
nested-scope precedence that subclass handlers already had.

The gap slipped through because the only behavioral test asserted a *child*
error is not rescued (which passes even when base-only is fully broken);
nothing asserted the exact class is rescued. Add that missing test.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Pull Request Pull Request #2794: Fix base-only rescue handlers never firing

Coverage Stats

1127 of 1222 branches covered (92.23%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

3595 of 3663 relevant lines covered (98.14%)

23345.68 hits per line