dangernoodle-io / breadboard / 29173560136

95%

push

github

refactor: drive smoke and floor composition from a single bbtool.toml manifest (#824)

- collapse examples/smoke/main/CMakeLists.txt's hand-written SMOKE_REQUIRES
  (+ board-conditional list(APPEND...) groups) and the Makefile's hand-typed
  --components strings into one [capability.smoke]/[board.*] manifest table
  in bbtool.toml, resolved via boards.py's existing resolve_component_names
- the resolved closure is now the SOLE, authoritative source of REQUIRES
  (idf_component_register(REQUIRES ${BB_AUTOWIRE_REQUIRES})) -- no more
  additive union of the generated fragment into a hand list; dropping a
  component from a board's manifest set now actually drops it
- fold bb_wifi_ap into capability.smoke.components (its prior omission from
  the Makefile's wire-only list was drift, not intent -- it carries no
  bbtool:init marker so this changes nothing functionally)
- add a stale-fragment guard: codegen embeds the resolved board id as
  BB_AUTOWIRE_BOARD in the generated fragment; examples/smoke's
  CMakeLists.txt hard-fails if it doesn't match the board actually being
  built (skipped during ESP-IDF's REQUIRES-only early-expansion pass, where
  externally -D'd vars like FIRMWARE_BOARD aren't populated yet)
- keep bb_app_init.c (wire) generation deliberately board-invariant via a
  new `--wire-board` codegen flag pinned to a fixed manifest baseline board,
  so board-parameterizing REQUIRES can't silently start wiring a
  board-conditional-only // bbtool:init marker (e.g. bb_display_info) on
  boards that never called it before -- byte-identical output verified
  against origin/main for every board
- move [capability.core] off `required = true` (which auto-applies to every
  board in the manifest) onto an explicit `capabilities = ["core"]` on
  [board.native] -- otherwise core's ~100-component host-scaffold list would
  have leaked into the new smoke/floor boards; net resolved set for native
  is unchanged
- same manifest-authoritative REQUIRES treatment... (continued)

3319 of 3319 branches covered (100.0%)

Branch coverage included in aggregate %.

5268 of 5268 relevant lines covered (100.0%)

9727.49 hits per line