dangernoodle-io / breadboard / 29066557506

96%

push

github

refactor: extract bb_core callback-slot helper; migrate bb_wifi ota-validated + on_disconnect seams (#803)

the "single-slot injected callback: static slot + setter + null-safe
dispatch" idiom appeared twice in bb_wifi (ota-validated query,
on_disconnect notify). extract it to bb_core/bb_callback_slot.h --
three macros (BB_CALLBACK_SLOT_RET, BB_CALLBACK_SLOT_VOID0,
BB_CALLBACK_SLOT_VOID) covering the return-value, no-arg-void, and
with-args-void shapes.

each macro's generated `invoke` reads its own file-static slot
directly -- no separate externally-linked dispatch(cb, ...) symbol --
so there's no undeclared-external surface and the real, shipped
instantiations are host-testable through their real public symbols
(set -> invoke).

the real seam instantiations live in
platform/host/bb_wifi/bb_wifi_emit.c, which is compiled into both the
host test binary and the ESP-IDF firmware, so runtime behavior is
host-tested via the exact shipped functions, not a copy:
- ota-validated (RET): bb_wifi_internal_ota_validated is both the
  macro's invoke and wifi_reconn.c's existing private accessor -- no
  extra wrapper.
- on_disconnect (VOID0): migrates the previously hand-rolled
  s_on_disconnect_cb + bb_wifi_register_on_disconnect onto the macro;
  the event_handler call site now calls bb_wifi_on_disconnect_invoke().

on_got_ip stays hand-rolled -- its late-registration replay behavior
(fires immediately if already connected) doesn't fit the plain slot
macro; noted for a future macro variant.

tighten the consolidation rule to trigger extraction at the SECOND
instance, and correct the wiki worked example to describe what's
actually migrated (the net-event sink is a further instance landing
in a follow-up PR).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

3313 of 3313 branches covered (100.0%)

Branch coverage included in aggregate %.

5259 of 5259 relevant lines covered (100.0%)

9671.33 hits per line