DrRataplan / xq-lsp / 29047442623

93%

push

github

fix: scope inline function params, window vars, and copy bindings for XPST0008

checkUndeclaredVariables never tracked bindings introduced by
InlineFunctionExpr params, window-clause WindowVars (current/positional/
previous/next item), or XQUF_TransformExpr copy bindings, so any reference
to them was wrongly flagged as undeclared (XPST0008). This was the single
largest source of false positives in the QT4 diagnostic snapshots (1206 of
1365 total), breaking almost every higher-order-function call.

The window variable itself is added to scope only after its start/end
conditions are processed, since it isn't bound yet while its own boundary
is being evaluated (confirmed via QT4's TumblingWindowExpr519 /
SlidingWindowExpr519).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

1005 of 1178 branches covered (85.31%)

Branch coverage included in aggregate %.

137 of 137 new or added lines in 2 files covered. (100.0%)

3651 of 3825 relevant lines covered (95.45%)

433737.06 hits per line