DrRataplan / xq-lsp / 29049894644

93%

push

github

fix: model QT4 environment-bound variables to cut XPST0008 false positives

Many QT4 test cases bind variables externally via <environment><param> or
<source role="$..."> instead of declaring them in the query text (the
harness equivalent of `declare variable $x external;`). The diagnostic
coverage harness only modeled <namespace> bindings from environments, so
these externally-bound variables were reported as XPST0008 (undeclared
variable), accounting for 665 of 824 total false positives across the
snapshot suite.

Extract <param>/<source role="$..."> bindings the same way <namespace>
bindings already are, and inject them into moduleVariables before running
diagnostics. Total false positives drop from 824 to 199, with XPST0008
false positives dropping from 665 to 40; false negatives are unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NywD7BhMcq8yyRG3b6pTba

1010 of 1183 branches covered (85.38%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 1 file covered. (100.0%)

3672 of 3846 relevant lines covered (95.48%)

431449.63 hits per line