Freegle / Iznik / 25886

72%

push

circleci

rippling: route ripple-eval to the routing server, not the KNN service

routingEvalURL() fell back to SPATIAL_KNN_URL when ROUTING_EVAL_URL was
unset. SPATIAL_KNN_URL addresses the KNN spatial server, which has no
POST /v1/ripple-eval — that endpoint is served by iznik-routing-go on its
internal no-auth listener. Both prod apiv2 and the regular local apiv2 set
SPATIAL_KNN_URL but not ROUTING_EVAL_URL, so every ripple-eval hit KNN,
404'd, scoreSample dropped every post, and the drive-time analytics went to
zero ("No drive-time sample" + all-grey bullseye). apiv2-live escaped it
only because it sets ROUTING_EVAL_URL explicitly (the routing tunnel).

Drop the SPATIAL_KNN_URL fallback: ROUTING_EVAL_URL, else the local-Docker
routing default (http://spatial:8194 = the routing container's
SPATIAL_INTERNAL_PORT). SPATIAL_SERVER_URL is intentionally not used as a
fallback either — it points at the routing server's 8196 auth port, which
401s an unauthenticated ripple-eval. Also set ROUTING_EVAL_URL explicitly
on the regular apiv2 in compose so it can't silently misroute.

Prod apiv2 (db1/2/3) additionally needs ROUTING_EVAL_URL=http://localhost:8197
in its .env (routing-go SPATIAL_INTERNAL_PORT there is 8197) — applied
separately, as prod sources a local .env not this compose file.

Test: routingEvalURL honours an explicit override, never falls back to
SPATIAL_KNN_URL, and defaults correctly when unset.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014yFzkxz5uFxTBCKTHqokGm

12939 of 17047 branches covered (75.9%)

Branch coverage included in aggregate %.

135408 of 188515 relevant lines covered (71.83%)

37.93 hits per line