dcdpr / jp / 28946719726

69%

Build Type

push

github

Committed by web-flow

Commit Message

chore(github, tools): Reject PR review comments outside diff (#857)

`add_review_thread` now returns the thread GitHub actually created,
including its resolved `line`. GitHub's `addPullRequestReviewThread`
mutation silently accepts anchors that fall outside the PR's diff hunks:
it creates a thread, but the review UI never renders it, so the comment
vanishes without any error. The mutation now also treats a missing/null
`thread` in the GraphQL response as a hard error instead of reporting
success for a no-op.

The `github_pr_review_add_comment` tool uses this to validate anchors
against the PR's diff before posting: it fetches the target file's
patch, parses commentable line ranges from the hunk headers, and rejects
`line`/`start_line` values that fall outside them, reporting the valid
ranges and the nearest commentable line so the caller can retry in one
follow-up call. The approval preview shown before posting carries the
same check as a non-fatal warning, so a reviewer sees the problem before
approving. A post-mutation check remains as a safety net for files
GitHub can't return a patch for (binary/oversized) and for races where
the PR head moves between validation and posting.

The `pr_review_add_comment` tool description documents the new anchoring
requirement.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

116 of 184 new or added lines in 2 files covered. (63.04%)

9 existing lines in 3 files now uncovered.

39162 of 57401 relevant lines covered (68.23%)

669.89 hits per line