MushroomObserver / mushroom-observer / 28933722186

99%

main: 99%

Pull #4722

github

Add Components::InputGroup and Components::ButtonGroup (#3797)

Second PR in the "Raw Bootstrap class sweeps" work on #3797 (Navbar
was first, #4721). Adds two components and routes every remaining raw
call site through them.

Components::InputGroup + InputGroup::Addon:
- InputGroup wraps the outer `.input-group` div.
- InputGroup::Addon wraps the trailing `<span>` — `variant: :btn`
  (default, `.input-group-btn`) for a Button/Link/submit, or
  `variant: :addon` (`.input-group-addon`) for a plain text addon.
- Refactored the existing Superform ApplicationForm::InputGroupAddon
  mixin (used by text_field/select_field's `button:`/`addon:` options)
  to delegate to these instead of hand-emitting the same divs/spans a
  third time - collapses what was 3 independent copies of this
  structure (the mixin, index_pagination_nav.rb, api_keys/form.rb) to
  1.
- BS4 renames `.input-group-btn` to `.input-group-append`/`-prepend`;
  BS5 drops the wrapping span entirely. Every caller now routes
  through one place for that swap.

Components::ButtonGroup:
- Wraps `.btn-group` and always emits `role="group"` - one of the
  three raw call sites it replaces (rss_logs/type_filters.rb,
  visual_groups/edit.rb, interests/index.rb) was missing it.
  `.btn-group` doesn't rename across BS3/4/5, so this one is DRY +
  accessibility motivated rather than version-churn motivated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

42 of 42 new or added lines in 9 files covered. (100.0%)

51750 of 52218 relevant lines covered (99.1%)

750.74 hits per line