MushroomObserver / mushroom-observer / 28933108860

99%

main: 99%

Pull #4721

github

Add Components::Navbar; route real navbar-* patterns through it (#3797)

Part of the "Raw Bootstrap class sweeps" checklist on #3797. Extracts
Components::Navbar for the recurring `.navbar-text` tag-wrapper
pattern (div/li/strong wrapping a small inline label, reused across
top_nav.rb, search_bar.rb, sorter.rb, index_pagination_nav.rb), plus
two class-string constants for patterns that don't share one fixed
DOM shape:

- LINK_CLASSES ("navbar-link btn btn-lg px-0") - the icon-button combo
  duplicated in index_pagination_nav.rb and show_prev_next_nav.rb.
- FORM_CLASS ("navbar-form") - sometimes a real <form> tag, sometimes
  a plain <div> wrapper, sometimes a wrapper_class: string handed to
  Dropdown, so it can't be a single tag-emitting component.

BS4 drops `.navbar-form` entirely and renames `.navbar-right`/
`.navbar-left` to margin-auto utilities - every caller that references
these instead of retyping the raw strings gets that swap in one place.

Deliberately out of scope: the outer `<nav class="navbar navbar-default">`
wrapper and its navbar-nav/navbar-right chrome in top_nav.rb, and
sidebar.rb's one-off "navbar navbar-inverse" styling constant. Both are
single call sites, and the former needs a real structural rewrite
(navbar-header/navbar-toggle removed in BS4) that the #3797 audit
already flagged as needing BS4 loaded to verify visually - not a
same-version class swap this PR can safely make.

navbar-flex (the pagination/sort-bar flex layout) is a MO-invented
custom class, not real Bootstrap, so it's left untouched throughout -
confirmed via `_top_nav.scss` before starting this sweep.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

19 of 19 new or added lines in 11 files covered. (100.0%)

51723 of 52191 relevant lines covered (99.1%)

752.02 hits per line