akvo / akvo-mis / #697

88%

push

coveralls-python

Feature/245 sync app changes from iwsims to akvo mis (#247)

* [#245] Fix SQLite busy errors on submit and stuck Fetching data spinner

- Add openDatabase() helper applying PRAGMA busy_timeout = 5000 to every
  app.db connection so concurrent writers wait instead of failing with
  'database is locked' (SQLITE_BUSY)
- Set busy_timeout on the SQLiteProvider connection in migrateDbIfNeeded
  on every launch
- Route all useNewConnection call sites (background tasks, inline
  submission task, logout) through the helper
- Use BEGIN IMMEDIATE in sql.withTransaction so the write lock is acquired
  where busy_timeout applies, avoiding WAL lock-upgrade busy failures
- Wrap Submission fetchData in try/catch/finally: loading state always
  clears, errors reported to Sentry and shown as toast instead of leaving
  the spinner stuck forever; drop the cosmetic 1s delay
- Fix getFormOptions binding 3 params to a 2-placeholder query

* [#245] Make question group list scrollable and fix stale required errors

- Wrap question group list in ScrollView and adjust container padding
- Add schema-based required-question counter (X/Y) in group list header,
  validating each required field with the same Yup schema used at submit
  so the count reflects actual submittability
- Compute the counter via a debounced, leak-safe effect (ignore flag +
  clearTimeout) to avoid revalidating the whole form on every keystroke
- Clear a stale "... is required" message as soon as a field is answered
  by refreshing that field's feedback on change, only when an error is
  currently shown (avoids per-keystroke validation/re-render)

5662 of 6567 branches covered (86.22%)

Branch coverage included in aggregate %.

10667 of 11894 relevant lines covered (89.68%)

0.9 hits per line