akvo / akvo-mis / #696

88%

push

coveralls-python

[#244] Re-enable bulk upload button & fix non-superadmin bulk Excel upload (#246)

* [#244] Uncomment the bulk upload button in DataFilters.js

Add upload permission for submitter

* [#244] Fix non-superadmin bulk Excel upload seeding

Bulk uploads submitted by non-superadmin users failed to seed correctly.
Three bugs on the non-superadmin path in seed_excel_data:

- batch.batch_data_list.add(data) raised TypeError (DataBatchList is a
  through model, not an m2m to FormData), aborting the seed after the
  first datapoint and leaving one answerless datapoint behind. Use
  DataBatchList.objects.create(batch=batch, data=data).
- approver.user.email raised AttributeError; batch.approvers() returns
  dicts. Use approver["user"].email.
- No DataApproval rows were created for the batch, so the batch showed
  an empty approver list in /batch/ and could never be approved. Create
  a pending DataApproval per approver, mirroring the POST /batch flow.

Add regression tests covering all three: rows seed with answers and
batch links, approver notification resolves, and the /batch/ endpoint
lists the batch approvers.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

5660 of 6567 branches covered (86.19%)

Branch coverage included in aggregate %.

10669 of 11894 relevant lines covered (89.7%)

0.9 hits per line