Freegle / Iznik / 25279

72%

master: 72%

Pull #984

circleci

fix(api): repair 15 cross-endpoint drift bugs found by the overlap review

Follow-up to the endpoint audit: a workflow review of all 274 routes for
overlapping/duplicate function confirmed 35 overlaps; these are the fixes for
every one with live consequences.

- donations: one canonical triggerGiftAidNotification (deleted IS NULL filter +
  ORDER BY id DESC + INSERT IGNORE, uniform columns) replacing two divergent
  copies; BulkUploadDonations now matches donors via
  MatchUserByEmailOrPriorDonation (gmail dot/plus variants + prior-donation
  fallback) instead of exact email, unblocking gift-aid linkage for recurring
  PayPal Giving Fund donors.
- chat: participant fetch for the review path gains the missing NOT EXISTS
  rippling_held_replies filter (held replies no longer leak).
- amp: PostChatReply now sets processingrequired=1/processingsuccessful=0
  (push notifications were silently dropped) and reopens CLOSED rosters,
  matching the normal chat path.
- location: typeahead SQL deduplicated into one shared query used by both
  endpoints; fixed the whitespace-normalisation no-op (ReplaceAll of the
  literal two-character sequence backslash-s).
- newsfeed: Count() no longer hard-codes a 1609m default the Feed doesn't use,
  and its inverted error check no longer enables filtering on a garbage
  distance param - badge and feed now agree.
- volunteering: V2 group listing regains V1's per-group volunteering-setting
  gate (the live regression); GET /volunteering/{id} gains renewed/url/online
  and https:// contacturl normalisation for V1 parity.
- communityevent: creators now see their own pending events on group pages,
  matching the personal feed.
- tryst: calendarLink rewritten to V1 form (/calendar?data= with participant
  names, 15-minute duration, Europe/London; embedded tzdata); parse fallbacks
  extracted to parseArrangedFor and covered.
- user: self-service account deletion now tears down sessions and skips the
  post-auth check, matching Forg... (continued)

12743 of 16811 branches covered (75.8%)

Branch coverage included in aggregate %.

132167 of 183174 relevant lines covered (72.15%)

38.0 hits per line