Freegle / Iznik / 25258

72%

master: 72%

Pull #984

circleci

chore(api): OpenAPI audit - document every live endpoint, delete dead ones, guard drift

Audit of all 272 routes across apiv2 (iznik-server-go), the routing server
(iznik-routing-go) and the spatial KNN server (iznik-spatial-go): every caller
in the monorepo was swept per endpoint, every zero-caller candidate adversarially
re-verified including out-of-repo callers (TrashNothing, IPN webhooks, the
housekeeper extension, app shell), and the OpenAPI definitions synced to what
the handlers actually do.

DELETED (verified unused, high confidence - registrations, handlers, docs, tests):
- apiv2: GET/PUT/PATCH/DELETE /isochrone (per-user isochrone CRUD, dead since the
  PR #921 reach flip; /isochrone/message and /message/count live on), plain
  GET /messages (ModTools uses /modtools/messages; ~18 dead-endpoint tests went
  with it), GET /activity, DELETE /message/{id}, GET /modtools/admin/{id},
  GET /modtools/alert/{id}, PATCH /config/admin, DELETE /noticeboard/{id},
  POST /story + DELETE /story/{id} (action-based; live /story/like + /story/unlike
  kept - their tests rewritten against the live routes, which previously had none),
  POST /team, DELETE /team, PATCH /microvolunteering, GET /simulation
- routing: GET /v1/posts-for-member
- spatial: GET /v1/datasets, GET /v1/{dataset}/status, GET /v1/{dataset}/within,
  GET form of within_coords (the POST form the routing server uses stays),
  global POST /v1/rebuild (per-dataset rebuild stays)

KEPT despite zero in-repo callers (external users verified): /changes (TN polls),
TN message endpoints, Stripe/PayPal IPNs, housekeeper extension endpoints incl.
/donations/bulk, /userdump (API-key third-party access), spammers export,
LoveJunk webhook.

LIVE BUG FIXED: ModTools alert click-tracking posted to /alert, a path that was
never registered (handler lives at /modtools/alert) - silently 404ing in
production. Client path corrected; endpoint kept and documented.

DOCS: ~40 previously undocumented endpoints now hav... (continued)

12749 of 16818 branches covered (75.81%)

Branch coverage included in aggregate %.

132027 of 183088 relevant lines covered (72.11%)

37.93 hits per line