kobotoolbox / kpi / 28770625340

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(auth): handle user names from IdP and metadata refactor DEV-2394 (#7215)

### 📣 Summary
Map standard SCIM name attributes (givenName, familyName, and formatted)
natively to Kobo user fields (User.first_name, User.last_name, and
ExtraUserDetail.data['name']) during SCIM provisioning.

### 📖 Description
Previously, Kobo's SCIM implementation did not natively capture standard
name payload attributes from the IdP when creating or updating users.
This resulted in new users appearing with empty full names inside the
Kobo frontend. This PR resolves the issue by intercepting the standard
SCIM core schema attributes for names and mapping them to their
appropriate Kobo storage locations:

* `name.givenName` → `User.first_name`
* `name.familyName` → `User.last_name`
* `name.formatted` → `ExtraUserDetail.data['name']`

- Refactored the core extraction logic inside
kobo/apps/kobo_scim/utils.py. Created a helper function
`get_scim_value()` that parses both nested JSON dictionaries and SCIM
extension URN paths
- Unified Metadata Application: Updated `apply_scim_user_metadata()` to
natively process standard SCIM core fields alongside the configurable
custom metadata mappings (`USER_METADATA_FIELDS`). Because this utility
handles all mapping, POST, PUT, and PATCH API requests automatically
receive this behavior without duplicating code in the view layer
- Updated `ScimUserSerializer.get_name()` to fetch the formatted name
from ExtraUserDetail so the SCIM API returns the correct data. It safely
falls back to concatenating first_name and last_name if formatted is
omitted

### 👀 Preview steps
1. Simulate the IdP pushing a brand-new user with a full `name` payload.

```bash
curl -X POST http://kf.local.kbtdev.org/scim/v2/<IDP_SLUG>/Users \
  -H "Authorization: Bearer <SCIM_API_KEY>" \
  -H "Content-Type: application/scim+json" \
  -d '{
    "schemas": ["urn:ietf:params:scim:schemas:core:2.0:User"],
    "userName": "curltestuser",
    "active": true,
    "emails": [
  ... (continued)

Coverage Stats

9263 of 12594 branches covered (73.55%)

3 of 75 new or added lines in 4 files covered. (4.0%)

1395 existing lines in 72 files now uncovered.

30228 of 37098 relevant lines covered (81.48%)

5.52 hits per line