Freegle / Iznik / 24970

72%

push

circleci

fix(digest): stamp lastsent on a pinned-only daily digest (stop re-send flood)

Incident 2026-07-05: 67 members received the daily digest up to ~198 times.
Cause: the daily digest always includes a pinned post (a940e6631), but pinned
posts are never part of the cursor set. sendDigest called
updateDigestTracker($allPosts), which only stamps users_digests.lastsent when it
has cursor posts. A user whose digest contained ONLY a pinned post therefore got
the email sent but lastsent left unstamped, so the once-per-London-day guard
(lastsent >= today) never fired and the everyMinute daily run re-sent them every
tick.

updateDigestTracker now takes emailWasSent; when true and there are no cursor
posts it still stamps lastsent (the cursor msgid/msgdate correctly stays put, as
a pinned post has no cursor entry). The daily send site passes true, since an
email is always sent once past the no_posts guards. The no-send paths keep the
default (false) so users we didn't mail are never marked sent.

Test: updateDigestTracker stamps lastsent with empty posts + emailWasSent=true,
and does not when false.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015DQRL5iGD71jNTgyokMpt9

12353 of 16327 branches covered (75.66%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

131265 of 183715 relevant lines covered (71.45%)

38.14 hits per line