Freegle / Iznik / 24846

73%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(mydata): stop the "My Data" page crashing on partial GDPR-export data

A flood of Vue render errors on production all traced to the My Data (GDPR export) page:
- "Cannot read properties of undefined (reading 'length')" and "t.items.slice is not a
  function": mydata.vue binds status.data.memberships to <ShowMore>, but that is undefined while
  the export loads. ShowMore's items prop was Array/required with no default, so its computeds
  crashed on props.items.length / .slice. Fixed: items defaults to [] and a safeItems guard
  wraps every access. ScrollGrid gets the same defensive guard on its visibleItems computed.
- "Cannot read properties of undefined (reading 'emailfrequency')" + "...(reading
  'eventsallowed')", firing per membership row: the template read s.item.mysettings.emailfrequency
  /.eventsallowed/.volunteeringallowed, but a membership row from the stored export can lack
  mysettings. Optional-chained all three (with a v-else-if so periodPlural(undefined) can't fire).

Verified against the code by an adversarial trace: EmailSettingsSection/SettingsGroup were NOT
crash sites (myGroups always builds fully-populated objects; SettingsGroup already guards).

Vitest 13863/0 (added ShowMore undefined/null items tests).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ZeG2zmg2JCR8pYEjAUaAk

Coverage Stats

12360 of 16334 branches covered (75.67%)

Branch coverage included in aggregate %.

17 of 23 new or added lines in 3 files covered. (73.91%)

36 existing lines in 1 file now uncovered.

131186 of 183671 relevant lines covered (71.42%)

37.96 hits per line