ben-manes / caffeine / #5583

100%

master: 100%

push

github

Keep write-behind running after an action throws

A throwing writeAction disposed the RxJava subscriber (it disposes
before routing the error, so an error consumer can't help), leaving the
PublishSubject observer-less so every later write was silently dropped.
Isolate the throw inside the subscriber. Also skip empty batches so an
idle buffer stops calling writeAction with empty maps, validate
bufferTime is positive, and observe on the IO scheduler since the write
action performs blocking work.

4080 of 4094 branches covered (99.66%)

8315 of 8323 relevant lines covered (99.9%)

1.0 hits per line