dangernoodle-io / breadboard / 28691251146

100%

push

github

feat(bb_sink_ws): WS egress sink with typed bidirectional envelope (#698)

add a bb_pub sink that registers /ws on the bb_websocket httpd transport
and broadcasts telemetry to subscribed clients, with a typed envelope
{"type":"push","topic":..,"data":..} and inbound demux on `type`
(`sub` -> per-client topic filter; other types ignored/logged).

- per-client fd->slot subscription map, bounded by BB_SINK_WS_MAX_CLIENTS
  (bridged from CONFIG_BB_HTTP_MAX_OPEN_SOCKETS)
- whitespace-tolerant inbound sub-frame JSON scan
- s_clients[] guarded by a dedicated mutex; broadcast snapshots matching
  fds under the lock and sends outside it (no send under lock)
- bb_websocket per-fd disconnect callback (bb_websocket_set_disconnect_cb)
  clears a client's subscription slot on socket close, preventing LWIP
  fd-reuse from bleeding a prior client's filter onto a new connection
- guard httpd_req_to_sockfd() < 0 so a failed lookup can't encode to the
  NULL "unset" sentinel and silently skip disconnect cleanup
- async broadcast re-checks the fd is still a live WS client before send,
  closing the closed-fd delivery window

host mirror + tests cover disconnect-clears-subscription, pool exhaustion,
reserved-type demux, legacy back-compat, and whitespace-tolerant parse.

follow-ups tracked: B1-549 (extract shared espidf/host parser core),
B1-550 (residual same-fd-reuse TOCTOU + on-target soak coverage).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

2260 of 2260 branches covered (100.0%)

Branch coverage included in aggregate %.

3784 of 3784 relevant lines covered (100.0%)

1203.37 hits per line