Freegle / Iznik / 24615

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(digest): send most-overdue-first + 08:00-12:00 window + 13:00 still-lagging alert

The daily digest streamed recipients in user-id order (lazyById). Since rippling ~tripled the
daily population (~79k) it no longer clears in the morning window, and id-order permanently
STARVES the same high-id tail — they never get a turn — while low ids get re-sent. Fix: stream
MOST-OVERDUE-FIRST (never-sent users, then oldest lastsent) via streamDailyOverdueFirst, a
memory-safe chunked keyset (id keyset for the never-sent phase; composite (lastsent,id) keyset
for the sent phase, both strictly forward so an un-stamped no-post user is never revisited). Now
the lag rotates fairly across everyone and self-corrects: as throughput rises the window reaches
further down the queue until it completes daily.

Restore the intended member-facing window to 08:00-12:00 UK local (Europe/London, BST-correct) —
reverting the temporary 23:59 catch-up widening. Add a 13:00 "still lagging" check that counts
recently-active recipients not sent today and logs at error level (→ Sentry) when it exceeds
FREEGLE_DIGEST_DAILY_LAG_ALERT_THRESHOLD (default 5000) — the capacity signal, firing until
throughput catches up. Test asserts the stream yields never-sent, then oldest, then most recent.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015DQRL5iGD71jNTgyokMpt9

Coverage Stats

12265 of 16221 branches covered (75.61%)

Branch coverage included in aggregate %.

52 of 52 new or added lines in 1 file covered. (100.0%)

32 existing lines in 2 files now uncovered.

130734 of 183216 relevant lines covered (71.36%)

37.85 hits per line