agama-project / agama / 28671708926

83%

Build Type

push

github

Committed by web-flow

Commit Message

Missing translations (#3688)

## Problem

Some strings are not translated. Missing translatated strings should be
detected by the linter, but there are two edge cases:

* Literal string directly passed as prop to a PF component.
* Literal strings marked for translation with `N_` but then it is not
translated with `_()`.

Examples:
~~~
<PFComponent foo="bar" />

const LABEL = N_("Disk");

<Text>{LABEL}</Text>
~~~

https://bugzilla.suse.com/show_bug.cgi?id=1269514

## Solution

Properly mark the literal strings for translations when they are used in
a prop and fix missing translations in storage UI components by
converting translation-marked constants to type-safe translation
functions.

Changes

* Replaced static translation-marked constants (FILESYSTEM_NAMES,
PARTITIONABLE_SPACE_POLICIES, VOLUME_GROUP_SPACE_POLICIES) with
dedicated translation functions (filesystemLabel,
partitionableSpacePolicyLabel, volumeGroupSpacePolicyLabel).
* Fixed untranslated space policy labels in SpacePolicyMenu and
SpaceActionsTable.
* Removed unused SIZE_UNITS constant.

Moving translation logic into functions ensures translations are always
applied and prevents future instances of forgotten translations.

In network, the connection type labels were not marked for translation.
Fortunatelly, there are already translations for that strings.

Coverage Stats

4900 of 6833 branches covered (71.71%)

Branch coverage included in aggregate %.

32 of 53 new or added lines in 3 files covered. (60.38%)

39 existing lines in 3 files now uncovered.

25559 of 29811 relevant lines covered (85.74%)

124.08 hits per line