agama-project / agama / 28667439712

83%

Build Type

push

github

Committed by web-flow

Commit Message

feat(web): allow disambiguate  form fields accessible name (#3685)

## Motivation

As a follow-up to #3684, which this PR actually supersedes, adds a
`useFieldLabel` hook that lets any form field adjust its accessible name
in a flexible way, reusing existing text nodes as a prefix for its
label, among other options, to disambiguate fields that share a generic
label without introducing new translatable strings.

The previous PR only fixed two "Mode" dropdowns on the System page that
shared the accessible name "Mode", making them indistinguishable to
screen readers, voice control, and automated tests. The fix lived only
in `DropdownField`, despite the same collision happening elsewhere. On
the Authentication page, the administrator and root sections each render
"Password", "Password confirmation" and "SSH Public Keys", so those
names are ambiguous across sections. Changing the visible labels is not
an option (they would read as redundant next to the section legend, and
also Agama is in a translation freeze at this moment), so the
disambiguation has to happen in the accessible name.

This PR generalizes the one-off approach into a reusable hook and rolls
it out to every field that renders a label.

## Main changes summary

### `useFieldLabel` hook

Resolves a field's accessible name from three independent options:

- `aria-label`: a literal name (consumer owns it).
- `aria-labelledby`: referenced element ids (consumer owns it).
- `labelPrefixedBy`: one or more element ids whose text is placed before
the field's own label, producing a name like "Hostname Mode". Unlike
`aria-labelledby`, the visible label is kept in the name (WCAG 2.5.3).

An explicit `aria-labelledby` wins over `labelPrefixedBy`. With no
options the hook is a no-op and the control keeps the label association
`FormGroup` already provides.

### Field rollout

All label-bearing fields accept the options: `TextField`, `MaskedField`,
`NumberField`, `EmailField`, `SuggestionsTextField`, `Dropdo... (continued)

Coverage Stats

4891 of 6806 branches covered (71.86%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 15 files covered. (100.0%)

23 existing lines in 5 files now uncovered.

25539 of 29753 relevant lines covered (85.84%)

124.14 hits per line