IJHack / QtPass / 28657019015

63%

push

github

fix: check process start for stdin-less commands so the queue can't stall (#1606)

Executor::executeNext() only ran waitForStarted() for commands that carry
stdin. A command WITHOUT stdin (most git/gpg/pass invocations) that failed to
start emitted QProcess::errorOccurred(FailedToStart) but never finished(), so
the finished handler that clears `running` and advances the queue never ran —
`running` stayed true forever and the entire FIFO queue stalled, freezing all
further password-store operations with no feedback.

Run the start check for every command regardless of stdin: on failure, emit an
error (deferred via a queued call, as before), dequeue, clear `running`, and
continue with the next item. The stdin-write path is unchanged.

Adds tst_executor::executeAsyncFailedToStartNoInputDoesNotStall, which queues a
failing no-input command followed by a valid one and asserts the error is
surfaced and the second command still completes (the queue did not stall).


Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

20 of 20 new or added lines in 1 file covered. (100.0%)

3811 of 6719 relevant lines covered (56.72%)

30.78 hits per line