IJHack / QtPass / 28650029157

63%

Build Type

push

github

Committed by web-flow

Commit Message

fix: prevent PasswordDialog content duplication and premature-save data loss (#1605)

* fix: prevent PasswordDialog content duplication and premature-save data loss

Two data-integrity bugs when editing an existing entry:

- setPassword() populated the free-text body with insertPlainText(), which
  appends. PasswordDialog listens to the shared Pass::finishedShow signal, so a
  second Show (a later one for any entry) re-ran the handler and appended a
  second copy of the body; getPassword() then saved the duplicated content back
  to the file. Use setPlainText() so re-populating replaces the body, and
  disconnect from finishedShow after the first (our) result so a later Show of a
  different entry can no longer overwrite or duplicate these fields.

- on_accepted() guarded with `if (newValue.isEmpty()) return;`, but
  getPassword() always returns at least a trailing newline, so the guard was
  dead code. Clicking OK before the asynchronous Show finished decrypting
  therefore overwrote the existing entry with the empty dialog fields. Track a
  m_contentLoaded flag (set when the entry's content arrives) and refuse to save
  an existing entry until it has loaded.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* fix: keep listening for finishedShow instead of disconnecting after first

finishedShow carries no request identity, so disconnecting after the first
signal risked consuming a stale queued Show as this dialog's result and never
seeing its own. The dialog is modal and always edits the selected entry, and
setPassword() replaces every field (so repeated results overwrite rather than
duplicate — the original duplication bug is fixed by setPlainText). Drop the
disconnect and rely on last-writer-wins instead.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------... (continued)

Coverage Stats

2 of 4 new or added lines in 1 file covered. (50.0%)

1 existing line in 1 file now uncovered.

3812 of 6720 relevant lines covered (56.73%)

30.77 hits per line