decentraland / social-service-ea / 28624024661

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix: harden WS transport, subscriptions, RPC startup and backpressure (#429)

* fix: harden WS transport, subscriptions, RPC startup and backpressure

Transport (UWebSocketTransport):
- Attach a no-op catch to each message future so fire-and-forget sends from
  @dcl/rpc can no longer surface as unhandled rejections (fatal under
  --unhandled-rejections=strict). Awaiting callers still observe rejections.
- After max retries, emit a transport error instead of silently dropping the
  message. A dropped stream frame stalls the ack loop forever and a dropped
  unary response hangs the client call; erroring lets the RPC server tear the
  transport down and the client reconnect.
- Don't re-kick the queue while a backoff retry is pending, and wire the uWS
  drain event through so queued messages retry the moment the socket drains
  instead of racing the backoff timer.
- Make close() idempotent and drop the dead pre-listener connect emit.

ws-handler:
- End the socket when the transport is closed by the RPC layer while the socket
  is still alive, so a client can't keep a live but dead session.
- Clear isConnected before closing the transport during cleanup so that guard
  is precise on the socket-initiated path instead of relying on uWS throwing.
- Guard ws.end() in the auth-failure path against an already-closed socket.
- Re-check isConnected after transport creation before attaching the user.
- Forward drain to the transport; capture the address before cleanup for the
  close log; count ws_messages_sent on actual outbound sends.

rpc-server / pubsub:
- Await the actual pub/sub subscription promises in start() (flatMap, not a
  forEach that resolved to undefined) and rethrow subscription errors so an
  instance can't boot with no subscriptions.

updates:
- Only announce a new friend as ONLINE on friendship-accept if they are
  actually connected (checked against peersStats), instead of fabricating
  presence.
- Add an optional initial-snapshot hook to handle... (continued)

Coverage Stats

2347 of 2754 branches covered (85.22%)

Branch coverage included in aggregate %.

95 of 104 new or added lines in 12 files covered. (91.35%)

3 existing lines in 2 files now uncovered.

5864 of 6339 relevant lines covered (92.51%)

80.35 hits per line