decentraland / social-service-ea / 28593221494

90%

push

github

fix: harden access control, referral integrity and adapter robustness (#428)

* fix: harden access control, referral integrity and adapter robustness

Findings from a security/correctness review, grouped by area.

Access control:
- Reject direct joins of private communities (require the request/invite flow)
- Enforce bans on the request/invite accept path and when creating requests;
  remove a banned user's pending requests so a ban cannot be circumvented
- Exclude banned users when bulk-accepting requests on a private->public flip
- Enforce block and reject self-calls in private voice chat; normalize social
  settings lookups so a checksummed address can't bypass privacy settings
- Normalize addresses in role-permission and block/unblock self checks

Referral integrity:
- Add a unique(invited_user) index (with dedupe) so one invited user maps to a
  single referrer, closing a reward-inflation race

Robustness / hardening:
- Fix voice-db "user is busy" guard (IN (array) -> = ANY(array))
- Default outbound HTTP request timeout; bound inbound WS payload size
- Escape LIKE/ILIKE wildcards in community search
- Bound placeIds array size; clamp falsy pagination limits
- Fix memory-cache mGet, redis get JSON resilience and EX handling, retrier
  error propagation, feature-flag refresh, interval-leak guards, catalyst
  server rotation, rewards response validation
- Stop leaking internal error details over WS; stop logging referral email PII

Adds unit and integration coverage for the ban-enforcement, voice block/self,
private-community join, and wildcard-escaping paths.

* fix: address PR review feedback

- rewards: log a warning when the reward server responds OK but without a
  data array, instead of silently returning []
- block/unblock: validate the address format before the self-block check so a
  malformed input reports "Invalid address" rather than "Cannot block yourself"
- queries: align the OFFSET guard with LIMIT (typeof offset === 'number')
- memo... (continued)

2314 of 2717 branches covered (85.17%)

Branch coverage included in aggregate %.

79 of 95 new or added lines in 24 files covered. (83.16%)

5802 of 6271 relevant lines covered (92.52%)

80.42 hits per line