decentraland / comms-gatekeeper / 28613949985

85%

main: 85%

Build Type

Pull #276

github

Committed by LautaroPetaccio

Commit Message

refactor: move sceneId->place resolution into the places component

- Add places.getPlaceBySceneId(sceneId, worldName?) and delete the standalone
  logic/scene-place helper. The places component gains the contentClient
  dependency (created before places in components.ts), so cast, scene-bans and
  comms-scene-handler no longer depend on contentClient directly.
- Callers resolve via places.getPlaceBySceneId, keeping the room<->place security
  invariant in one place.
- Add places-component tests for getPlaceBySceneId covering the Genesis City and
  (multi-scene) world resolution paths.

Pull Request Pull Request #276: fix: address security audit findings (access control, disclosure, hardening)

Coverage Stats

1121 of 1436 branches covered (78.06%)

Branch coverage included in aggregate %.

85 of 94 new or added lines in 21 files covered. (90.43%)

4 existing lines in 1 file now uncovered.

3081 of 3486 relevant lines covered (88.38%)

75.03 hits per line