kobotoolbox / kpi / 28600649892

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(bulkProcessing): skip already-accepted versions in bulk-accept DEV-2385 (#7208)

### 📣 Summary
The bulk-accept endpoint (`POST
/api/v2/assets/{uid_asset}/data/supplements/bulk/`) was re-stamping
`_dateAccepted` and counting already-accepted submissions on every call,
making `accepted_count` misleading. Added a guard in
`BulkAcceptSerializer.accept()` to skip versions where `_dateAccepted`
is already set.

### 📖 Description
Calling the bulk-accept endpoint multiple times for the same submission
always returned `accepted_count: 1` (or more), even though no new
acceptance action was performed. The caller had no way to distinguish
"just accepted" from "already accepted".

This PR adds an early continue in the per-supplement loop when
latest_version.get(`_dateAccepted`) is already truthy. Already-accepted
versions are now silently skipped `_dateAccepted` is not modified and
the supplement is excluded from `to_update`, so `accepted_count`
correctly reflects only newly accepted records.

Coverage Stats

9262 of 12602 branches covered (73.5%)

0 of 2 new or added lines in 1 file covered. (0.0%)

22 existing lines in 3 files now uncovered.

30216 of 37102 relevant lines covered (81.44%)

5.52 hits per line