lsm / neokai / 28573718941

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(space): align worker agent tool profiles with runtime inheritance semantics (#2214)

* fix(space): align worker agent tool profiles with runtime inheritance semantics

After PR #2199 the runtime treats a worker agent's non-empty tools list as an
explicit override profile and inherits all other SDK built-ins. The UI was still
showing stale restrictive allowlists, so presets and the editor now reflect the
actual policy:

- Coder, General, Planner, Research, and Coordinator default to an empty
  permissive profile (inherit all SDK built-ins).
- Reviewer keeps read/search/delegation tools plus Task/TaskOutput/TaskStop and
  denies Bash along with the other mutation tools.
- QA keeps Bash for running tests while denying Write/Edit/MultiEdit/
  NotebookEdit.
- deriveWorkerDisallowedTools now includes Bash in the mutation deny-list.
- Empty tools arrays are preserved in the DB as '[]' so the UI knows inheritance
  is explicit rather than unset.
- SpaceAgentEditor shows 'SDK defaults are always inherited', marks denied
  mutators, and presets map to the new semantics.
- Updated unit tests for seed agents, agent config, custom agent init, space
  agent manager, and SpaceAgentEditor.

* test: update worker-agent tool expectations for CI shards

- Allow empty permissive tool profiles in built-in template assertions.
- Include Bash in long-horizon agent mutation deny-list expectations.

* fix(web): address review P3 findings on agent tools editor

- Update stale test header comment: empty tool profile is valid.
- When the last checked tool is toggled off, switch back to the Inherited
  preset instead of leaving Custom active with an empty list.
- Add test covering the Inherited transition after unchecking all tools.

* fix(web,space): address QA findings on agent editor and worker list

QA raised three issues after the initial fix; all addressed here.

1. Inherit-mode checkboxes were all unchecked, which read as 'no tools'
   even though the banner says all S... (continued)

Coverage Stats

11493 of 16569 branches covered (69.36%)

Branch coverage included in aggregate %.

51 of 54 new or added lines in 4 files covered. (94.44%)

19 existing lines in 2 files now uncovered.

97983 of 116269 relevant lines covered (84.27%)

301.24 hits per line