lsm / neokai / 28562532172

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: inline session rename for chat + space sessions (#2215)

* feat(session): skip auto-title generation for user-renamed sessions

Add a titleSetBy metadata flag ('user' | 'auto') and accept it via
UpdateSessionRequest.metadata. generateTitleAndRenameBranch now early-returns
when a user has renamed, so the auto-gen job never clobbers a manual rename.

* feat(web): add useSessionRename hook

Centralizes inline-rename state and the optimistic commit pipeline (optimistic
title update, await session.update with titleSetBy, rollback + toast on failure).
Enter/blur commits, Esc cancels, auto-select-all on focus, and a settled-guard
prevents double-commit when Enter/Esc unmount the input.

* feat(web): inline rename for chat + space sessions

Wire useSessionRename into all four session-list surfaces: the chat sidebar
(SessionListItem) and the three space rows (SpaceDetailPanel, SpaceOverview,
SpaceSessionsPage). Each renders an inline input in place of the row while
editing, shows a hover-revealed pencil (with stopPropagation where the row
navigates), and supports double-click to edit. Shares a RenameIcon component.

* fix(web): hover-revealed pencil on SpaceSessionsPage + row a11y/click target

Address review feedback on PR #2215:
- SpaceSessionsPage rename pencil now uses the hover-revealed classes
  (opacity-0 group-hover/row:opacity-100) matching the other surfaces, with
  group/row on the row.
- SpaceOverview/SpaceDetailPanel rows regressed from <button> to <div> in the
  initial change; restore keyboard activation (role=button, tabIndex, Enter/Space
  handler guarded so the nested pencil doesn't double-fire) and move the click
  handler to the outer row so the full row + status dot stay clickable.

* fix: harden rename guardrail + optimistic update (Codex review)

Address the 4 review comments on PR #2215:
- TOCTOU: generateTitleAndRenameBranch re-checks titleSetBy after the async
  model + branch-rename work (before the write), so a manual rename t... (continued)

Coverage Stats

11464 of 16535 branches covered (69.33%)

Branch coverage included in aggregate %.

74 of 94 new or added lines in 8 files covered. (78.72%)

1 existing line in 1 file now uncovered.

98008 of 116273 relevant lines covered (84.29%)

301.41 hits per line