iotaledger / iota / 28559452709
68%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1109
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.801% (-0.05%) from 67.85%
28559452709

push

github

web-flow 
refactor(consensus): remove dead v29 flag-off branches from the consensus runtime (#11994)

# Description of change

The four consensus protocol flags first enabled for mainnet at protocol
version 29 are now treated as permanently active. Their flag-off runtime
branches are dead and have been removed. The flag definitions and
historical per-version values remain in `iota-protocol-config`.

**`consensus_fast_commit_sync`**

Uses `TransactionRef` unconditionally across block proposal, commits,
`DagState`, storage, cordial knowledge, authority RPCs, and the header,
transaction, and commit synchronizers. This removes the legacy
header-based commit-sync verification path, pre-versioned
shard/transaction deserializers, and endpoint guards.

**`consensus_block_restrictions`**

Makes acknowledgment and commit-vote limits, round bounds, GC eviction,
and the quorum-commit-round proposal skip unconditional.

**`consensus_median_timestamp_with_checkpoint_enforcement`**

Makes checkpoint timestamp monotonicity enforcement unconditional.

**`always_advance_dkg_to_resolution`**

Always advances pending random-beacon DKG state so persisted state can
resolve without new inbound traffic.

The cleanup also removes obsolete test matrices and setup,
`verify_transactions_with_headers`, `SerializedTransactionsV1`, the
`FastCommitSyncNotEnabled` error,
`GenericTransactionRef::expect_block_ref`, vestigial `Context` storage
parameters, and the legacy BlockRef-keyed transaction maps and RocksDB
column family.

## Compatibility

Commit digests include the BCS enum tag. The legacy `CommitV1` and
`ShardWithProofV1` variant slots therefore remain as deserialize and
format anchors, while their construction is removed.
`GenericTransactionRef` also retains both variants. Legacy V1 commits
and shards still deserialize, and peer-supplied V1 data is rejected by
the existing version checks.

The consensus RocksDB path is epoch-scoped as
`storage_base_path/{epoch}`. A v29 epoch creates a f... (continued)

628 of 659 new or added lines in 22 files covered. (95.3%)

560 existing lines in 49 files now uncovered.

159556 of 235331 relevant lines covered (67.8%)

458857.06 hits per line

Uncovered Changes

Lines Coverage ∆ File
10
95.0
 1.01% crates/starfish/core/src/transactions_synchronizer.rs
6
95.54
 0.32% crates/starfish/core/src/commit_solidifier.rs
4
88.33
 0.94% crates/starfish/core/src/commit_syncer/regular.rs
4
93.38
 -0.14% crates/starfish/core/src/storage/rocksdb_store.rs
3
82.1
 -0.07% crates/starfish/core/src/network/tonic_network.rs
3
89.42
 -0.74% crates/starfish/core/src/storage/mem_store.rs
1
80.13
 -4.3% crates/starfish/core/src/commit.rs

Coverage Regressions

Lines Coverage ∆ File
90
60.17
 -0.88% crates/iota-json-rpc-types/src/iota_transaction.rs
72
53.97
 0.0% crates/iota/src/validator_commands.rs
43
77.37
 1.09% crates/iota-sdk/src/wallet_context.rs
35
55.42
 0.0% crates/iota-archival/src/reader.rs
30
80.13
 -4.3% crates/starfish/core/src/commit.rs
22
56.42
 -0.48% crates/iota-storage/src/lib.rs
21
73.87
 -0.29% crates/test-cluster/src/lib.rs
19
90.43
 0.81% crates/iota-protocol-config/src/lib.rs
18
0.0
 0.0% crates/iota-tool/src/db_tool/mod.rs
18
91.36
 -1.65% crates/starfish/core/src/block_header.rs
16
65.29
 0.0% crates/iota-archival/src/lib.rs
16
71.17
 -4.93% crates/iota-json-rpc/src/lib.rs
16
84.24
 -0.2% crates/iota-json-rpc/src/read_api.rs
15
71.12
 0.28% crates/iota-json/src/lib.rs
10
90.65
 0.0% crates/iota-genesis-builder/src/stardust/migration/verification/basic.rs
10
94.54
 -0.37% crates/starfish/core/src/core.rs
9
88.76
 0.0% crates/iota-genesis-builder/src/stardust/migration/verification/util.rs
7
73.88
 0.14% crates/iota-network/src/randomness/mod.rs
7
85.97
 -0.5% crates/iota-transaction-builder/src/lib.rs
6
73.53
 -17.65% crates/iota-genesis-builder/src/stardust/types/output_header.rs
6
46.9
 -5.31% crates/iota-genesis-builder/src/stardust/types/snapshot.rs
6
91.85
 -4.44% crates/iota-package-management/src/lib.rs
6
50.0
 -21.43% crates/iota-types/src/collection_types.rs
6
78.9
 -0.72% crates/iota-types/src/crypto.rs
5
79.23
 0.55% crates/iota-core/src/traffic_controller/mod.rs
4
88.28
 -0.34% crates/iota-genesis-builder/src/lib.rs
4
56.08
 1.4% crates/iota-json-rpc-types/src/iota_object.rs
3
87.25
 -1.2% crates/iota-core/src/authority_server/mod.rs
3
75.73
 -2.91% crates/iota-grpc-server/src/server.rs
3
75.86
 0.0% crates/iota-snapshot/src/reader.rs
3
66.67
 0.0% crates/iota-storage/src/object_store/mod.rs
3
72.2
 -0.62% crates/iota-swarm/src/memory/swarm.rs
3
89.03
 1.08% crates/iota-test-transaction-builder/src/lib.rs
3
69.74
 7.37% crates/starfish/core/src/transaction_ref.rs
2
81.83
 -0.06% crates/iota-core/src/authority.rs
2
93.81
 4.12% crates/iota-core/src/connection_monitor.rs
2
88.89
 -0.27% crates/iota-network/src/discovery/mod.rs
2
90.71
 -0.24% crates/iota-network/src/state_sync/mod.rs
2
64.0
 0.0% crates/iota-replay/src/config.rs
2
94.26
 0.75% crates/starfish/core/src/authority_service.rs
2
82.1
 -0.07% crates/starfish/core/src/network/tonic_network.rs
1
86.11
 0.0% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
98.5
 -0.3% crates/iota-core/src/signature_verifier.rs
1
0.0
 0.0% crates/iota-metrics-push-client/src/client.rs
1
66.67
 -2.08% crates/iota-network-stack/src/anemo_ext.rs
1
95.54
 0.32% crates/starfish/core/src/commit_solidifier.rs
1
98.07
 0.66% crates/starfish/core/src/cordial_knowledge.rs
1
96.34
 0.0% crates/starfish/core/src/dag_state.rs
1
99.45
 -0.09% crates/starfish/core/src/linearizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 28559452709.1 1109
67.8
 GitHub Action Run
Source Files on build 28559452709