iotaledger / iota / 28487821551
68%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1109
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.85% (+0.4%) from 67.438%
28487821551

push

github

web-flow 
upstream(starfish-simtests): drop dead network_type and use integration-test layout (#12065)

# Description of change

- Port of upstream PRs:
- [MystenLabs/sui#24760](https://github.com/MystenLabs/sui/pull/24760) —
remove the dead `network_type` from the simtest config
- [MystenLabs/sui#22601](https://github.com/MystenLabs/sui/pull/22601) —
move the starfish simtests into the standard integration-test layout
- Description:

Two small cleanups to the `starfish-simtests` crate:
- Remove the unused `network_type` field (and its `ConsensusNetwork`
import / destructure / construction site) from the simtest `Config`. It
was already marked `#[expect(dead_code)]`.
- Move `src/tests/simtests.rs` to `tests/simtests.rs` so it runs as a
Cargo integration test against the crate's public API. `node.rs`'s
`Config`, `AuthorityNode`, `RestartMode`, and `make_authority` are made
`pub`, `node` becomes a public module, and `rand` moves to
`[dev-dependencies]`. The simtests can now be run from the repo root via
the `simtests` test target.

Adapted to the fork: applied to develop's current simtest files (which
have since been refactored downstream) rather than cherry-picked, so
only the above changes are included.

## Links to any relevant issues

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

Verified under the simulator from the repo root: the crate builds as the
`simtests` integration-test target and
`devnet_sequential_restarts_clean_db_short_run_short_stop` passes.

160183 of 236085 relevant lines covered (67.85%)

478598.01 hits per line

Coverage Regressions

Lines Coverage ∆ File
632
0.0
 0.0% external-crates/move/crates/move-analyzer/src/symbols.rs
504
81.89
 0.32% crates/iota-core/src/authority.rs
213
90.94
 -0.13% crates/iota-core/src/authority/authority_per_epoch_store.rs
213
77.14
 -0.39% crates/iota-core/src/checkpoints/mod.rs
189
87.28
 0.01% crates/iota-node/src/lib.rs
167
70.4
 0.52% crates/iota-core/src/grpc_indexes.rs
125
72.08
 -1.05% crates/iota-core/src/authority_server/validator.rs
123
80.91
 0.18% crates/iota-core/src/authority_aggregator.rs
108
61.05
 0.3% crates/iota-json-rpc-types/src/iota_transaction.rs
94
83.42
 11.2% crates/iota-core/src/transaction_orchestrator.rs
85
85.62
 0.63% crates/iota-config/src/node.rs
74
89.62
 0.26% crates/iota-protocol-config/src/lib.rs
72
83.51
 -2.64% crates/typed-store/src/database.rs
68
79.95
 8.67% crates/iota-core/src/authority_server/validator_v2.rs
65
77.84
 -6.52% crates/iota-types/src/messages_consensus.rs
62
83.48
 0.17% crates/iota-types/src/transaction.rs
62
92.29
 -0.01% iota-execution/latest/iota-adapter/src/programmable_transactions/context.rs
58
28.42
 0.31% crates/iota-core/src/transaction_driver/error.rs
56
82.09
 4.68% crates/iota-core/src/safe_client.rs
52
93.94
 -0.02% crates/starfish/core/src/authority_node.rs
49
92.09
 92.09% crates/iota-core/src/transaction_driver/effects_certifier.rs
49
53.66
 -39.84% crates/iota-transaction-builder/src/package.rs
48
93.67
 1.3% crates/iota-core/src/consensus_adapter.rs
47
92.72
 1.14% crates/iota-core/src/authority/consensus_quarantine.rs
45
31.37
 -28.76% external-crates/move/crates/move-package/src/resolution/dependency_cache.rs
42
82.35
 -1.58% crates/iota-grpc-server/src/transaction_execution_service/mod.rs
42
0.0
 0.0% external-crates/move/crates/move-analyzer/src/analyzer.rs
38
91.55
 -1.28% crates/iota-core/src/consensus_handler.rs
37
57.79
 1.89% crates/iota-core/src/test_authority_clients.rs
36
61.66
 0.2% crates/iota-network-stack/src/client.rs
31
64.67
 0.0% crates/iota-types/src/storage/mod.rs
30
94.22
 0.01% crates/starfish/core/src/leader_schedule.rs
29
58.97
 0.64% crates/iota-cluster-test/src/cluster.rs
29
76.1
 0.0% crates/iota-json-rpc/src/lib.rs
22
88.45
 0.14% crates/iota-core/src/authority_server/mod.rs
22
54.69
 -3.08% crates/iota-json-rpc-types/src/iota_object.rs
21
96.62
 0.98% crates/iota-core/src/overload_monitor.rs
19
87.95
 -2.52% crates/iota-test-transaction-builder/src/lib.rs
19
74.17
 -0.1% crates/test-cluster/src/lib.rs
16
83.71
 83.71% crates/iota-core/src/transaction_driver/mod.rs
15
85.29
 0.97% crates/iota-core/src/post_consensus_validation.rs
15
85.0
 0.16% crates/iota-swarm-config/src/node_config_builder.rs
15
28.57
 -71.43% crates/iota-types/src/transaction_executor.rs
14
95.02
 -0.05% crates/iota-types/src/move_package.rs
14
82.17
 0.54% crates/starfish/core/src/network/tonic_network.rs
13
84.14
 -2.88% crates/iota-core/src/consensus_manager/mod.rs
12
94.0
 -0.27% crates/typed-store/src/rocks/options.rs
11
91.28
 -0.39% crates/iota-core/src/consensus_validator.rs
10
44.16
 -12.99% crates/iota-types/src/messages_grpc.rs
9
10.0
 0.0% crates/simulacrum/src/transaction_executor.rs
9
97.24
 0.03% crates/typed-store/src/rocks/mod.rs
8
77.78
 -6.94% crates/iota-config/src/transaction_deny_config.rs
8
92.08
 0.55% crates/iota-core/src/authority/test_authority_builder.rs
8
73.74
 -0.58% crates/iota-network/src/randomness/mod.rs
8
46.76
 -1.37% crates/iota-sdk/src/apis/read.rs
8
53.44
 0.89% crates/iota-types/src/iota_sdk_types_conversions.rs
7
0.0
 0.0% crates/iota-types/src/transaction_driver_types.rs
6
95.83
 0.07% crates/iota-cluster-test/src/lib.rs
6
91.91
 0.0% crates/iota-core/src/epoch/randomness.rs
6
78.32
 -2.1% crates/iota-sdk/src/lib.rs
6
64.67
 -3.59% crates/iota-types/src/iota_system_state/mod.rs
5
94.66
 1.52% crates/iota-cluster-test/src/test_case/coin_index_test.rs
5
89.13
 89.13% crates/iota-core/src/transaction_driver/transaction_submitter.rs
5
55.77
 -9.62% crates/iota-json-rpc-types/src/iota_coin.rs
5
89.47
 0.0% iota-execution/latest/iota-adapter/src/error.rs
4
68.42
 -0.33% crates/iota-core/src/authority/authority_store.rs
4
0.0
 -80.0% crates/iota-types/src/messages_safe_client.rs
3
81.75
 -0.75% crates/iota-config/src/genesis.rs
3
78.68
 0.28% crates/iota-core/src/traffic_controller/mod.rs
3
96.17
 0.07% crates/iota-core/src/transaction_driver/request_retrier.rs
3
82.14
 2.68% crates/iota-genesis-builder/src/validator_info.rs
3
22.22
 -2.38% crates/iota-json-rpc-types/src/iota_checkpoint.rs
3
76.28
 -1.09% crates/iota-sdk/src/wallet_context.rs
3
98.31
 0.0% crates/iota-single-node-benchmark/src/single_node.rs
3
66.67
 -33.33% crates/iota-types/src/clock.rs
3
91.3
 -1.34% crates/iota-types/src/quorum_driver_types.rs
2
91.98
 -0.84% crates/iota-http/src/lib.rs
2
89.8
 0.83% crates/starfish/core/src/commit_syncer/fast.rs
1
86.11
 -2.78% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
89.69
 0.69% crates/iota-core/src/connection_monitor.rs
1
93.1
 5.6% crates/iota-core/src/validator_client_monitor/metrics.rs
1
94.62
 39.86% crates/iota-core/src/validator_client_monitor/monitor.rs
1
92.21
 0.0% crates/iota-types/src/inner_temporary_store.rs
1
93.99
 -0.07% crates/starfish/core/src/transactions_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 28487821551.1 1109
67.85
 GitHub Action Run
Source Files on build 28487821551