Freegle / Iznik / 24239

72%

push

circleci

fix(browse): count mygroups via messages_groups membership, not spatial.groupid

The "All my communities" (browseView=mygroups) unread badge was computed from
messages_spatial.groupid, which stores only ONE group per post and so
mis-attributes rippled/cross-posted messages. That diverged from the rendered
feed (message.Groups), which tests membership via messages_groups: rippled-in
posts were undercounted, and a spatial row left pointing at a member group
after the post was removed/retracted there was counted but never shown - a
residual "Mark seen" could never clear (stuck at 2/18/39 for the three
FifeFreegle owners on live prod).

Count's mygroups branch and the shared myGroupsMsgIDs now test membership via
EXISTS(messages_groups mg JOIN memberships ... collection='Approved' AND
deleted=0), matching the feed exactly, so badge == feed and Mark seen drains
to zero. Count keeps successful=0, a subset of what the feed marks. Live prod:
fix count == feed unseen (348==348 for Derek).

Also deprecate the now-unused isochrone-polygon CRUD endpoints and drop the
dead client stubs. The isochrone editor was removed in the rippling-out reach
flip (PR #921); no current client calls GET/PUT/PATCH/DELETE /isochrone.
Removed IsochroneAPI.{add,fetchv2,patch,del} (only fetchMessages, the Nearby
feed, remains) and marked the four routes deprecated in routes.go, the handler
doc-comments, the go-swagger source and the generated swagger.json.
/isochrone/message and /message/count are unchanged.

Tests: new TestMyGroupsCountsRippledInPost and
TestMyGroupsCountExcludesStaleSpatialRow. Go suite 3336 pass; vitest 13592 pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lp7GjxhERvpt6peTWrFPo4

11374 of 13094 branches covered (86.86%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 2 files covered. (100.0%)

128477 of 181696 relevant lines covered (70.71%)

36.56 hits per line