nats-io / nats.go / 28513504688

85%

Build Type

push

github

Committed by web-flow

Commit Message

[FIXED] MsgsTimeout iterator yields spurious (nil, nil) after a timeout (#2099)

NextMsg timeout returns ErrTimeout, which is not fatal, so a consumer is
allowed to keep ranging over MsgsTimeout. After yielding (nil, ErrTimeout)
the loop fell through to yield(msg, nil) with msg == nil and err == nil,
delivering a spurious (nil, nil) pair after every timeout. A consumer that
treats err == nil as a valid message then operates on a nil *Msg.

Add a continue after the non-fatal timeout branch so the iterator loops back
to NextMsg instead. Matches the Msgs() iterator, which returns after any
error. Adds a regression test that keeps iterating across timeouts; it failed
before the fix (got nil msg with nil error) and passes after.

Signed-off-by: Sueun Cho <sueun.dev@gmail.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

33 existing lines in 2 files now uncovered.

14831 of 17373 relevant lines covered (85.37%)

34255.45 hits per line