Freegle / Iznik / 24149

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(ripple): never join/insert a poster into a group they are banned from

Rippling could silently undo a moderator ban. Both join sites in
ExpandService ignored users_banned:
- rippleIntoNewGroups (site A) rippled the post INTO a banned group.
- addPosterMembershipToRippledGroups (site B) re-joined the banned poster
  (rippled=1 membership).

The leave-guard never caught it: a normally-banned user's most-recent
Group/Joined is 'Manual'/'Auto' (not 'Rippled'), so the guard's Rippled
condition never fired and users_banned was never consulted.

Fix:
- Site A: NOT EXISTS users_banned AND NOT EXISTS memberships collection='Banned'.
- Site B: NOT EXISTS users_banned (Banned-collection already blocked by the
  existing-membership check).
- Backfill: ExpandService::pullBannedRippleMemberships() + ripple:remove-banned
  command (dry-run default, --commit/--user/--limit). Removes rippled=1
  memberships into banned groups and soft-deletes their rippled-in post copies,
  one row per statement (Galera-safe); never touches organic memberships.
- Tests: post-not-rippled-when-banned (users_banned and collection='Banned'),
  backfill removes + dry-run writes nothing, organic membership untouched.

Prod dry run: 40 banned ripple-join pairs, 158 rippled-in copies.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AgH6Y917X3Nge6KbB4nw6M

Coverage Stats

11904 of 15811 branches covered (75.29%)

Branch coverage included in aggregate %.

49 of 69 new or added lines in 2 files covered. (71.01%)

27 existing lines in 5 files now uncovered.

128296 of 179982 relevant lines covered (71.28%)

36.92 hits per line