dangernoodle-io / breadboard / 28393993118

100%

push

github

fix(bb_pub): eliminate self-deadlock in meta_gather tick path (#601)

meta_gather is invoked by bb_pub_tick_once under the non-recursive
s_tick_lock (telem Phase 1).  It called bb_pub_get_status and
bb_pub_sink_info which both acquire that same lock, causing a permanent
self-deadlock: the bb_pub worker hangs, telemetry stops publishing,
and /api/info (pub_sinks section) wedges httpd.

fix:
- add bb_pub_get_status_nolock / bb_pub_sink_info_nolock in bb_pub.c;
  these read the same fields without re-acquiring s_tick_lock (safe
  when called with the lock already held)
- add bb_pub_priv.h (private internal header) declaring the two helpers
- switch meta_gather to call the _nolock variants; all external callers
  (http handlers, /api/info) continue using the locking public API
- add test hooks bb_pub_telemetry_meta_{gather,serialize,snap_size}_for_test
- add host tests: meta_gather_tick_no_deadlock (hang = regression),
  meta_gather_sink_count_parity (nolock values match public api)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1838 of 1838 branches covered (100.0%)

Branch coverage included in aggregate %.

3160 of 3160 relevant lines covered (100.0%)

1243.15 hits per line