decentraland / social-service-ea / 28393307615

90%

push

github

fix: stop duplicate-subscription log flood; add wsConnectionId + metric (#422)

Duplicate stream subscriptions are an expected, benign outcome of the
per-(address, event) guard, but were logged at WARNING per occurrence,
flooding the logs during reconnect/re-subscribe churn.

- Count them via a new `subscription_duplicates_total` metric (labelled by
  event) and drop the per-occurrence line to debug, so observability stays
  intact (graph/alert on the rate) without any log volume.
- Thread `wsConnectionId` into the RPC context (attachUser -> attachTransport)
  so the duplicate and teardown logs identify the originating connection.
- Move the "cleaning up subscription" log into handleSubscriptionUpdates'
  finally, which is only reached for subscriptions that were actually
  established; the duplicate guard returns before that try/finally, so rejected
  duplicates no longer emit a misleading cleanup line. Removes the now-redundant
  per-service finally logs across all subscribe handlers.

2295 of 2700 branches covered (85.0%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 8 files covered. (100.0%)

5745 of 6235 relevant lines covered (92.14%)

77.37 hits per line