decentraland / social-service-ea / 28379017890

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix: cancel unconsumed fetch response bodies to avoid undici socket leaks (#421)

* fix: cancel unconsumed fetch response bodies to avoid undici socket leaks

After the migration to native fetch (@dcl/fetch-component / undici), the
keep-alive socket backing a response stays pinned until the body is read or
cancelled. Paths that discard a response without consuming the body (non-ok
early throws/returns, void success paths, and fire-and-forget requests) leaked
those sockets until GC.

Add a drainResponse helper (src/utils/fetch.ts) that cancels the body only when
it hasn't been read, and apply it at every discard site:

- adapters/comms-gatekeeper.ts: drain the !ok branch of every method; for the
  void methods (updateUserPrivateMessagePrivacyMetadata, endCommunityVoiceChatRoom,
  requestToSpeakInCommunityVoiceChat, rejectSpeakRequestInCommunityVoiceChat,
  promoteSpeakerInCommunityVoiceChat, demoteSpeakerInCommunityVoiceChat,
  kickUserFromCommunityVoiceChat, muteSpeakerInCommunityVoiceChat) also drain the
  success path; endPrivateVoiceChat drains its new else branch;
  getCommunityVoiceChatStatus drains both the 404 return-null and the !ok throw.
- adapters/places-api.ts, adapters/archipelago-stats.ts, adapters/registry.ts
  (both fetch sites), logic/referral/referral.ts: drain the !ok branch.
- adapters/email.ts: drain the ok success return (the !ok path already reads text()).
- adapters/cdn-cache-invalidator.ts: capture the fire-and-forget request and drain it.
- logic/community/events.ts: drain the !ok return false branch.

adapters/rewards.ts already consumes the body on both paths (json() on ok,
text() in the error message), so it was left unchanged.

Verification: yarn build, eslint on changed files, full unit suite
(106 suites / 1596 tests) and full integration suite (49 suites / 602 tests)
all pass.

* refactor: rename drainResponse to discardResponseBody and fix events.ts drain ordering

Address PR review:
- Rename drainResponse -> discardRe... (continued)

Coverage Stats

2289 of 2696 branches covered (84.9%)

Branch coverage included in aggregate %.

72 of 79 new or added lines in 9 files covered. (91.14%)

1 existing line in 1 file now uncovered.

5753 of 6247 relevant lines covered (92.09%)

77.13 hits per line