Freegle / Iznik / 23996

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(verify): re-send email verification for an existing UNVALIDATED address

handleEmailVerify short-circuited on ANY address already on the user's account:
it made the row primary and returned WITHOUT sending the confirmation mail. So a
user whose address was attached but never validated (validated IS NULL) could
never get a verification mail - every "save/verify" click just re-made it primary
and returned. The user kept clicking "send verification", saw the UI confirmation,
but no mail ever left (confirmed on the relay: zero send attempts for the address
on the days they clicked, while ordinary notifications to it delivered fine).

Fix: only skip re-sending when the existing row is already validated. An
unvalidated existing row now falls through to (re)generate a validatekey and spool
the VerifyEmailMail, exactly like a brand-new address.

Verified live: queued a fresh email_verify task for the stuck user; the handler
fell through, wrote a new validatekey, and the relay logged the "Please verify
your email" message to the address with status=sent (250 ok).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aXkxBPEiPSJBaRMjz7opk

Coverage Stats

10765 of 12348 branches covered (87.18%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

1342 existing lines in 42 files now uncovered.

124343 of 176287 relevant lines covered (70.53%)

36.88 hits per line