Freegle / Iznik / 23976

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(chat): graceful reply errors instead of fatal "Oh Dear" page

Replying to a post whose messages row has been purged hit the
chat_messages.refmsgid -> messages.id FK on db.Create, which failed; the
handler only checked newid==0, threw away the real error, and returned a
generic 500. The apiv2 access log drops 500s and nothing reached Sentry, so
the failure was invisible. Diagnosed from user 40898048 / POST
/chat/20939833/message -> 500 (room created, message insert FK-failed, empty
room later purged).

Server (iznik-server-go/chat/chatmessage.go, CreateChatMessage):
- Guard refmsgid before insert: if the referenced message is missing or
  deleted, return 404 "refmsg_gone" instead of an FK 500 (mirrors the existing
  check in CreateChatMessageLoveJunk).
- Stop swallowing the db.Create error: check .Error and log it (chat, user,
  refmsgid) so this class of failure is diagnosable.

Frontend (iznik-nuxt3/components/ChatFooter.vue, send):
- The ongoing in-chat composer had no try/catch, so any non-2xx (this 500, and
  the widespread 403 not_in_reach) threw to the global error.vue page. Catch
  it: keep the typed text, reset sending, and show an inline notice
  (403 -> reaches-your-area, 404 -> no-longer-available, else -> generic).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

11330 of 15074 branches covered (75.16%)

Branch coverage included in aggregate %.

5 of 43 new or added lines in 2 files covered. (11.63%)

131 existing lines in 6 files now uncovered.

124398 of 175007 relevant lines covered (71.08%)

37.22 hits per line