Freegle / Iznik / 23827

72%

push

circleci

fix(contentcheck): exclude rippled-in groups from SubjectRepeat check

checkSubjectRepeat counts distinct groups carrying the same subject in the
window to catch mass-submission spam, but did not exclude rippled-in rows.
Rippling-out (ExpandService::rippleIntoNewGroups) inserts one
messages_groups row per nearby group for the SAME message, so a single
post's subject fans out to 20-30 groups — tripping the check and stamping
every rippled copy with "Subject recently posted to N different groups",
which surfaces as a yellow "suspicious" review panel on a legitimately
rippled post (Discourse #9808/250, Neville Reid: one NW-London offer
rippled to 32 groups flagged as if spam).

Add `WHERE messages_groups.rippled_in = 0` so only native postings count
(verified: the reported post drops from 32 distinct groups to 1). Genuine
cross-group spam still has rippled_in = 0 rows and is unaffected. Mirrors
the same exclusion already applied to checkIpAbuse in 4b6d7b3c3.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aXkxBPEiPSJBaRMjz7opk

11303 of 15030 branches covered (75.2%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

124048 of 174504 relevant lines covered (71.09%)

37.33 hits per line