lsm / neokai / 28217507108

82%

push

github

feat(web): surface terminal result errors inline in MinimalThreadFeed (#2187)

* feat(web): surface terminal result errors inline in MinimalThreadFeed

A completed Space task turn ending in a terminal result error
(error_during_execution / error_max_turns / etc.) previously only surfaced
the error behind the small amber ResultInfoButton dropdown — the turn bubble
itself stayed bg-dark-800 and the errors[] were hidden behind a click.

Now the CompletedBody bubble paints red (bg-red-900/20 border-red-800) and
surfaces a one-line error summary (first error string, or a humanized subtype
label fallback) inline at the top of the bubble, so a terminal error is
visible at a glance without opening the dropdown.

error_max_budget_usd is excluded from the inline red treatment (hitting a
budget cap is a deliberate cost guard, not an execution failure); it keeps
the existing amber dropdown trigger.

* fix(web): keep terminal-error turns visible in MinimalThreadFeed

A turn ending in a terminal result error with no assistant reply text
(e.g. a run that hit error_max_turns before writing anything, or crashed
mid-tool-use) was silently dropped by the empty-body filter in
buildFeedTurns — so the red bubble + inline error summary never rendered.

Exempt result-error turns from the filter: the red bubble IS the visible
content. Added a test reproducing the error-only-turn scenario.

* fix(web): keep all error result turns visible and fold their notifications

Two review-feedback gaps in the empty-text turn handling:

1. Budget-cap turns (error_max_budget_usd) with no assistant text were
   still dropped by the final empty-body filter because they were excluded
   from isInlineTerminalResultError. The visibility exemption now covers
   ALL error subtypes via isSDKResultError — the red-bubble treatment
   (isInlineTerminalResultError) remains narrower and is decided separately
   in CompletedBody.

2. The completedRows pre-scan also filtered on empty text, so error-only
... (continued)

11423 of 16451 branches covered (69.44%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 1 file covered. (100.0%)

96111 of 114721 relevant lines covered (83.78%)

299.3 hits per line