lsm / neokai / 28216386435

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(github): capture reply/resolve handles in the event normalizer (#2192)

* feat(github): capture reply/resolve handles in the event normalizer

Add `commentId` (REST numeric comment id) and `nodeId` (GraphQL node_id of
the comment/review/PR) to NormalizedGitHubEvent, extracted across every
normalizer branch (webhook issue_comment / pull_request_review /
pull_request_review_comment / pull_request, polling issue_comments /
review_comments / pulls, and check_run / reaction defaults).

These are the handles an agent needs to reply to and resolve a comment,
verified against the official GitHub REST + GraphQL reference:
- commentId is what `POST .../pulls/{n}/comments/{comment_id}/replies`
  (and the `in_reply_to` body param) needs.
- The review-THREAD node id required by `resolveReviewThread`
  (`ResolveReviewThreadInput.threadId`) is intentionally NOT captured: a
  comment's node_id is not its thread's node id, and GitHub does not include
  the thread node id in webhook/REST payloads — it must be resolved at
  runtime via the PR's `reviewThreads` connection.

Additive only: fields are captured and propagated to the ExternalEvent
payload; no behavior change. The companion formatter task (A) consumes them.

* fix(github): capture ROOT review comment id for the reply handle

The REST reply endpoint POST .../comments/{comment_id}/replies requires a
top-level review comment id, not a reply's own id (GitHub docs: "This must
be the ID of a top-level review comment, not a reply to that comment.").
Review threads are flat, so a reply's in_reply_to_id points at the thread
root. Resolve commentId to the root via in_reply_to_id for both the webhook
pull_request_review_comment branch and the polling review_comments path;
issue comments stay on their own id (issue comments are not threaded).
nodeId is unchanged (it intentionally references the triggering comment).

Adds focused tests: a reply review comment (webhook + polling) yields the
ROOT comment id, not the reply id.

Coverage Stats

11396 of 16422 branches covered (69.39%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 1 file covered. (100.0%)

23 existing lines in 1 file now uncovered.

96097 of 114707 relevant lines covered (83.78%)

299.31 hits per line