dangernoodle-io / breadboard / 28206242515

100%

push

github

fix(bb_ota_pull): resolve GitHub cross-host redirect before chunked OTA download (#559)

bb v0.41.0 / #313 enabled partial_http_download=true + keep_alive_enable=true
in bb_ota_pull to reduce peak TLS record buffer size on heap-constrained boards.
However, GitHub release asset URLs (github.com/.../releases/download/...) issue
a 302 redirect to a CDN (objects.githubusercontent.com). The HTTP Range-request
path used by partial_http_download does not reliably follow cross-host redirects,
causing release downloads to fail with "download failed after 3 attempts" (B1-354).

Fix: pre-resolve the redirect immediately before handing the URL to esp_https_ota.
A short-lived HEAD request (auto-redirect enabled, falling back to Range GET if
the CDN rejects HEAD with 403/405) fetches the final CDN URL. On any probe failure
the original URL is used (graceful fallback — never makes things worse). The CDN
signed URL is time-limited (~5 min); the probe runs immediately before the download
so the URL is always fresh. partial_http_download=true and keep_alive_enable=true
are kept — the heap savings are still needed on no-PSRAM boards.

The decision logic is extracted into bb_ota_pull_resolve_redirect_url() (pure,
portable, host-testable). Six new host tests cover all branches: redirect→CDN URL,
no-redirect→original, probe-failed→fallback, null/empty resolved→fallback,
null out_did_redirect→no crash. Coverage remains 100%.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1752 of 1752 branches covered (100.0%)

Branch coverage included in aggregate %.

2924 of 2924 relevant lines covered (100.0%)

1268.34 hits per line