lsm / neokai / 28195810905

71%

Build Type

push

github

Committed by web-flow

Commit Message

fix: render api_retry/thinking_tokens/task_notification roster-only in the minimal feed (#2188)

* fix: render api_retry, thinking_tokens, task_notification roster-only in the minimal feed

The minimal feed's main thread body is the multi-agent conversation; the
roster is its dedicated operational-status surface. Operational metadata
was leaking into the main thread as cards, duplicating the roster.

Move three system subtypes to roster-only in MinimalThreadFeed:
- api_retry: roster 'api_retry' entry (existing). Removed main-thread
  system turn + dead builder + orphaned collectRosteredApiRetryUuids.
- thinking_tokens: roster 'thinking' entries (existing). Removed
  main-thread system turn + dead builder.
- task_notification: folds onto its roster tool card when the tool is
  within the 8-entry cap; otherwise a new standalone roster entry
  (RosterTaskNotificationEntry, chat-container style) so the outcome is
  never lost. Removed the main-thread fallback card. Standalone
  suppression uses the global rosteredToolUseIds set to avoid cross-turn
  duplication. The drop-empty-turns filter now keeps turns with roster
  content so a degenerate turn (e.g. a killed task with no reply text)
  isn't dropped along with its outcome.

The chat container (SDKMessageRenderer) is unchanged — it still renders
all three as before.

* fix: prevent task_notification fold+standalone duplication in roster-only turns

In roster-only completed turns (tool + result, no assistant reply text),
a post-result task_notification folded onto its tool card AND rendered as
a standalone roster entry — because the rostered-tool pre-scan
(completedRows) excluded text-less turns, so the global rostered set
lacked those tool ids.

Two fixes:
- Broaden the pre-scan flush to include slices with tool_use content
  (not just assistant text), so text-less roster-bearing turns
  contribute their tool ids to the global rostered set.
- Gate standalone suppression on the global set UNION the curre... (continued)

Coverage Stats

11367 of 16392 branches covered (69.34%)

Branch coverage included in aggregate %.

32 of 32 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

95496 of 113740 relevant lines covered (83.96%)

300.83 hits per line