lsm / neokai / 28143109352

82%

push

github

feat: bounded 5xx/overloaded retry path in query-runner with backoff (#2184)

* feat: bounded 5xx/overloaded retry path in query-runner with backoff

Add a bounded retry path for 5xx / overloaded / provider-unavailable errors
that escape the SDK's own retry logic. Previously these went terminal
(session.error -> idle/blocked) on the first occurrence.

Changes:
- query-runner.ts: replace isRetry boolean with retryAttempt counter so the
  existing 1-shot paths (startup-timeout, message-not-found, transient-
  connection) keep their 1-shot semantics while the new provider path can
  fire up to the configured cap (default 3) with exponential backoff
  (2s/4s/8s). The counter is the unbounded-loop guard.
- The bounded path re-enqueues _lastConsumedUserMessage, displays a sanitized
  retry notice, closes queryObject, waits for subprocess exit, then sleeps
  the backoff before retrying -- mirroring the transient 1-shot at :957.
- On exhaustion, falls through to the existing terminal path with a dedicated
  'temporarily unavailable, retried N time(s)' user message.
- transient-error-patterns.ts: add RETRYABLE_PROVIDER_ERROR_SUBSTRINGS and
  isRetryableProviderError() which excludes 4xx/auth/quota/model_not_found
  (terminal, never retried). 429 stays on the RateLimitWatchdog path.

Config (env, read lazily for test override):
  NEOKAI_PROVIDER_MAX_RETRIES (default 3)
  NEOKAI_PROVIDER_RETRY_BASE_DELAY_MS (default 2000)

Tests: 17 integration tests in query-runner.test.ts + 34 unit tests in the
new transient-error-patterns.test.ts covering detection, guards, exhaustion,
re-enqueue, close-before-retry, cap enforcement, and terminal exclusion.

Relates to B1 (529 mapping), B2 (broadened transient patterns), B3 (body
normalization) -- built against the existing pattern set, widens as those land.

* fix: address review feedback on bounded retry path

Address 5 of 6 review comments from chatgpt-codex-connector[bot]:

P1: Re-check cancellation before retrying after ... (continued)

11362 of 16393 branches covered (69.31%)

Branch coverage included in aggregate %.

135 of 136 new or added lines in 2 files covered. (99.26%)

95485 of 113753 relevant lines covered (83.94%)

300.79 hits per line