agama-project / agama / 28167434874

83%

master: 83%

Pull #3667

github

fix(web): keep software pattern checkbox ids unique across categories

The pattern checkbox derived its DOM id, its label's htmlFor target, and
its React key from the pattern name. If the backend lists the same pattern
name under more than one category, those collide: duplicate ids make every
label resolve to the first input, and React keys clash.

Derive the DOM id and key from the category and position instead, keeping
the form field keyed by the pattern name. The backend selects patterns by
name, so duplicate entries represent the same selection and now stay in
sync without breaking the markup. Distinct patterns that merely share a
visible label remain independent and are told apart by their category
group.

4883 of 6817 branches covered (71.63%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

25403 of 29652 relevant lines covered (85.67%)

124.24 hits per line