agama-project / agama / 28161979348

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): unify localization settings into a single form (#3661)

## Summary

- Replace the three standalone localization selector pages (language,
keyboard, time zone) with a **single TanStack form** on the Localization
page, matching the shape of `system-form`, `registration-form`, and
`authentication-form`.
- Each selector is a `SearchableSelectField` typeahead: filter by name,
territory / country, code and (for time zones) UTC offset; rows show the
human name with the code de-emphasized, and the time zone's current
local time + offset.
- Introduce `SearchableSelectField`, a reusable typeahead combobox that
powers the three selectors (see its own section below).
- Show the explanatory text (installer language/keyboard adjustable from
the top bar) at the top of the
  page, before the fields, instead of below the form.


## Motivation / context

The Localization page used three `Page.Section` blocks, each linking out
to a separate full-page radio-list selector that committed on its own
and navigated back. That diverged from the rest of the app, where
settings live in one form
with a single submit. This unifies the experience.

## SearchableSelectField (new component)

A reusable typeahead combobox following the W3C "editable combobox with
list autocomplete" ARIA pattern, introduced here and used by all three
selectors:

- **Full-string search:** each option carries the complete text to match
(`filterText`, label included), so it filters by pieces not shown in the
visible label (codes, territory); the visual `description` is rendered
but never searched.
- **Accent-insensitive matching:** the query and option text are
sanitized (lowercased + diacritics stripped), so "ingles" matches
"Inglés". **`normalizeQuery`:** an optional last-resort callback to
rewrite the query before matching, for the rare case where a natural way
of typing should match an option it otherwise would not (here: a typed
"UTC+1" matches a zone whose offset is stored as "+1", wh... (continued)

Coverage Stats

4883 of 6817 branches covered (71.63%)

Branch coverage included in aggregate %.

239 of 265 new or added lines in 13 files covered. (90.19%)

3 existing lines in 3 files now uncovered.

25399 of 29648 relevant lines covered (85.67%)

124.0 hits per line