lsm / neokai / 28137518390

82%

push

github

fix: correct reviewer gh api review-body contract (forbid -f body=@-) (#2178)

* fix: correct reviewer gh api review-body contract (forbid -f body=@-)

The reviewer agent was posting PR reviews whose body was the literal string
"@-" instead of the intended review. Root cause: it ran
`cat <<'EOF' | gh api ... -f body=@-`, assuming `gh api` reads stdin via `@-`
the way curl does. It does not — `gh api`'s `-f` field posts the `@`-prefixed
value verbatim, so the heredoc body was silently discarded.

Fix the Reviewer System Contract (`system-contracts.ts`):
- Replace the fragile inline `-f body='...'` example (which breaks on any
  apostrophe in the body — the fragility that drove the @- workaround) with a
  command-substitution + quoted-heredoc form:
    -f body="$(cat <<'EOF' ... EOF)"
  Verified end-to-end that this posts the full multi-line body incl. quotes.
- Add an explicit warning: never use `-f body=@-` or `-f body=@/path`.
  Empirically confirmed lowercase `-f` does NOT interpret any `@`-prefixed
  value (neither `@-` stdin nor `@/path` file); it posts them literally.
- For large bodies, point to the RAW-field form `-F body=@/tmp/review.md`
  (capital F is the only flag that reads `@path`).

Add a regression test pinning the contract: it must warn against `@-`, teach
the heredoc command-substitution form, and no longer carry the old inline
single-quote body example.

Cleanup: the 6 stray "@-" reviews on merged PR #2157 have been edited via
GraphQL `updatePullRequestReview` to an explanatory note (submitted COMMENTED
reviews cannot be deleted/dismissed). Scanned the last 30 merged PRs — no
other "@-" review bodies found.

* fix: correct -F/--field vs -f/--raw-field naming in review-body contract

Addresses Codex review feedback (P2) on #2178: the temp-file guidance
mislabeled -F as "--raw-field". Per `gh api --help`, the flag that reads
@<path>/@- is the TYPED flag -F/--field, while -f/--raw-field is string-only.

Verified the full behavior matrix... (continued)

11363 of 16393 branches covered (69.32%)

Branch coverage included in aggregate %.

95311 of 113566 relevant lines covered (83.93%)

300.73 hits per line